Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8SPSMDB-1146: User management improvements and roles management #1647

Merged
merged 79 commits into from
Sep 26, 2024
Merged

K8SPSMDB-1146: User management improvements and roles management #1647

merged 79 commits into from
Sep 26, 2024

Conversation

inelpandzic
Copy link
Contributor

@inelpandzic inelpandzic commented Sep 10, 2024 •
edited
Loading

K8SPSMDB-1146 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Couple of issues were find in the initial implementation (stated in the Jira task), this PR addresses them all.

This PR also implements roles management: https://perconadev.atlassian.net/browse/K8SPSMDB-1124

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Sep 10, 2024
@pull-request-size pull-request-size bot added size/XL 500-999 lines and removed size/L 100-499 lines labels Sep 12, 2024
@inelpandzic inelpandzic marked this pull request as ready for review September 12, 2024 09:34
@inelpandzic @github-actions
Update pkg/psmdb/mongo/models.go
48e77d5 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pooknull
pooknull previously approved these changes Sep 19, 2024
View reviewed changes
egegunes
egegunes requested changes Sep 19, 2024
View reviewed changes
e2e-tests/run-release.csv Outdated Show resolved Hide resolved
egegunes
egegunes requested changes Sep 24, 2024
View reviewed changes
pkg/apis/psmdb/v1/psmdb_types.go Outdated Show resolved Hide resolved
inelpandzic and others added 2 commits September 24, 2024 10:16
@inelpandzic @github-actions
Update pkg/apis/psmdb/v1/psmdb_types.go
6736b9e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inelpandzic
Merge branch 'main' into K8SPSMDB-1146-user-mgmt-improvements
73f7fae
@hors hors self-requested a review September 25, 2024 10:38
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 failure
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 52 out of 52

commit: 9959fb7
image: perconalab/percona-server-mongodb-operator:PR-1647-9959fb75

@hors hors merged commit 9d424ed into main Sep 26, 2024
16 of 17 checks passed
@hors hors deleted the K8SPSMDB-1146-user-mgmt-improvements branch September 26, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@pooknull pooknull pooknull approved these changes

@egegunes egegunes egegunes approved these changes

@hors hors hors approved these changes

@tplavcic tplavcic Awaiting requested review from tplavcic tplavcic is a code owner

@nmarukovich nmarukovich Awaiting requested review from nmarukovich nmarukovich is a code owner

@ptankov ptankov Awaiting requested review from ptankov ptankov is a code owner

@jvpasinatto jvpasinatto Awaiting requested review from jvpasinatto jvpasinatto is a code owner

@eleo007 eleo007 Awaiting requested review from eleo007 eleo007 is a code owner

Assignees
No one assigned
Labels
size/XXL 1000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@inelpandzic @JNKPercona @hors @egegunes @pooknull @eleo007